Last modified: 2014-10-16 11:52:43 UTC
Created attachment 13464 [details] Initial css (from mediawiki.ui.vector.css) The native "Save Changes" button in the corner here on Bugzilla looks horrible (at least on my Browser+OS combo). Lets try applying some style (how about the new mw.ui buttons being used in Vector).
Created attachment 13465 [details] Button style without css (OSX + Firefox)
Created attachment 13466 [details] Button style with modified mw.ui css
If you would like to turn this into a Gerrit patch, the code is at https://git.wikimedia.org/tree/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/skins%2Fcontrib%2FWikimedia
Change 106864 had a related patch set uploaded by 01tonythomas: Gave Bugzilla's "Save Changes" button style. https://gerrit.wikimedia.org/r/106864
(Maybe my comment 3 towards the bug reporter was confusing for third parties, as it might have implied that I recommend and already support this change.) So the proposed style can be seen e.g. for "Create another account" on https://en.wiktionary.org/w/index.php?title=Special:UserLogin&returnto=Wiktionary%3AMain+Page&type=signup but not for "Save" at the bottom of https://www.mediawiki.org/wiki/Special:Preferences?useskin=vector which is semantically close enough to Bugzilla's "Save Changes" button. Hence I am not convinced why we should introduce such style inconsistency and make buttons look that much different from all other UI elements in our Bugzilla, but I welcome good arguments. :) Technically: For approaches to make Bugzilla look more like MediaWiki's Vector skin, editing the CSS file /skins/contrib/Wikimedia/vector.css feels like a better fit.
(In reply to Andre Klapper from comment #5) > why should we introduce such style inconsistency and make buttons look > that much different from all other UI elements in our Bugzilla? Daniel: ping?
(In reply to Andre Klapper from comment #6) > (In reply to Andre Klapper from comment #5) > > why should we introduce such style inconsistency and make buttons look > > that much different from all other UI elements in our Bugzilla? > > Daniel: ping? If that's an issue how about widening the scope of the bug? An interested party could try to restyle all the other form inputs to match those vector styles being created.
Alright, however I wonder how to keep Bugzilla CSS and MediaWiki UI in sync in the long run...