Last modified: 2014-03-08 16:06:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52186, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50186 - Guided tours cannot distinguish between read and edit modes with VisualEditor


Summary:	Guided tours cannot distinguish between read and edit modes with VisualEditor

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GuidedTour (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Matthew Flaschen

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-06-25 18:22 UTC by Steven Walling
Modified:	2014-03-08 16:06 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
This tour step should only be shown in read mode. (283.14 KB, image/png) 2013-06-25 18:22 UTC, Steven Walling	Details
Add an attachment (proposed patch, testcase, etc.)

Description Steven Walling 2013-06-25 18:22:33 UTC

Created attachment 12636 [details]
This tour step should only be shown in read mode.

When starting the guided tour via the "Show help" help button with GettingStarted, guided tours thinks I am in read mode and displays broken steps, rather than skipping to the appropriate editing steps.

Comment 1 Steven Walling 2013-06-25 18:26:15 UTC

Note: this only happens if the user clicks "Show help" after editing in VE mode. Otherwise, the tour progresses normally. The easiest solution in the interim may be to ensure that we don't show the Getting Started toolbar in VE edit mode, like we do for wikitext editing.

Comment 2 Gerrit Notification Bot 2013-07-09 03:19:22 UTC

Change 72677 had a related patch set uploaded by Mattflaschen:
Add support for VisualEditor.

https://gerrit.wikimedia.org/r/72677

Comment 3 Gerrit Notification Bot 2013-07-09 03:21:51 UTC

Change 72682 had a related patch set uploaded by Mattflaschen:
Add tour for VisualEditor

https://gerrit.wikimedia.org/r/72682

Comment 4 Matthew Flaschen 2013-07-09 03:23:02 UTC

This should be fixed by https://gerrit.wikimedia.org/r/#/c/72677/ and https://gerrit.wikimedia.org/r/#/c/72682/, pending review.

Comment 5 Matthew Flaschen 2013-07-09 09:22:31 UTC

I fixed the issue where step 1 was shown when clicked "Show help" while in VE editor, on a page with an ambox.  That's on toro for testing.

Comment 6 Steven Walling 2013-07-16 23:33:04 UTC

(In reply to comment #5)
> I fixed the issue where step 1 was shown when clicked "Show help" while in VE
> editor, on a page with an ambox.  That's on toro for testing.

Tested and working for me on toro. Once the patches are merged I think we can call this one fixed.

Comment 7 Gerrit Notification Bot 2013-07-18 16:35:59 UTC

Change 72677 merged by Ori.livneh:
Add support for VisualEditor

https://gerrit.wikimedia.org/r/72677

Comment 8 Gerrit Notification Bot 2013-07-18 20:22:00 UTC

Change 72682 merged by jenkins-bot:
Add tour for VisualEditor

https://gerrit.wikimedia.org/r/72682

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links