Last modified: 2014-03-08 16:06:55 UTC
Created attachment 12636 [details] This tour step should only be shown in read mode. When starting the guided tour via the "Show help" help button with GettingStarted, guided tours thinks I am in read mode and displays broken steps, rather than skipping to the appropriate editing steps.
Note: this only happens if the user clicks "Show help" after editing in VE mode. Otherwise, the tour progresses normally. The easiest solution in the interim may be to ensure that we don't show the Getting Started toolbar in VE edit mode, like we do for wikitext editing.
Change 72677 had a related patch set uploaded by Mattflaschen: Add support for VisualEditor. https://gerrit.wikimedia.org/r/72677
Change 72682 had a related patch set uploaded by Mattflaschen: Add tour for VisualEditor https://gerrit.wikimedia.org/r/72682
This should be fixed by https://gerrit.wikimedia.org/r/#/c/72677/ and https://gerrit.wikimedia.org/r/#/c/72682/, pending review.
I fixed the issue where step 1 was shown when clicked "Show help" while in VE editor, on a page with an ambox. That's on toro for testing.
(In reply to comment #5) > I fixed the issue where step 1 was shown when clicked "Show help" while in VE > editor, on a page with an ambox. That's on toro for testing. Tested and working for me on toro. Once the patches are merged I think we can call this one fixed.
Change 72677 merged by Ori.livneh: Add support for VisualEditor https://gerrit.wikimedia.org/r/72677
Change 72682 merged by jenkins-bot: Add tour for VisualEditor https://gerrit.wikimedia.org/r/72682