Last modified: 2014-10-28 20:24:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57356, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55356 - Log full URLs that hit the blacklist as well on Special:Log/spamblacklist
Log full URLs that hit the blacklist as well on Special:Log/spamblacklist
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
Spam Blacklist (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-05 20:57 UTC by Liangent
Modified: 2014-10-28 20:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-10-05 20:57:35 UTC
In addition to just the part that matches regex.
Comment 1 Kunal Mehta (Legoktm) 2013-10-05 21:19:02 UTC
I'm not sure if there will be a simple way to do this without breaking b/c...
Comment 2 MZMcBride 2013-10-05 21:21:27 UTC
I'm still not completely comfortable with the idea of logging full (blacklisted) URLs like this. I think this may have been an intentional design decision?
Comment 3 Kunal Mehta (Legoktm) 2013-10-05 21:22:34 UTC
(In reply to comment #2)
> I think this may have been an intentional design decision?

No, it was an oversight on my part.
Comment 4 Liangent 2013-10-05 21:56:12 UTC
(In reply to comment #2)
> I'm still not completely comfortable with the idea of logging full
> (blacklisted) URLs like this. I think this may have been an intentional
> design
> decision?

Anyway in contrast, abuse log (Extension:AbuseFilter) contains every detail of an editing action, even when it's rejected.
Comment 5 Dirk Beetstra 2014-01-20 11:08:35 UTC
I think this REALLY should be added ASAP - spammers use redirects to spam their sites anyway, and hits like 'goo.gl', 'ow.ly', and 'tinyurl.com' do not help at all.  Having the full link enables us to find what is being linked to, and whether or not the spam problem still exists (please, do 'disable' the links by removing the 'http://'-part, no need to accidentally click a bad link).  Thanks!  --~~~~
Comment 6 Dirk Beetstra 2014-08-10 03:34:54 UTC
Can we please have a fix for this.

In addition, a way to find links that were attempted to be spammed would be a nice addition as well.  It is now nigh impossible to find tried to add http://www.xxx.com.
Comment 7 Kunal Mehta (Legoktm) 2014-10-10 07:07:33 UTC
Un-cookie licking.
Comment 8 Gerrit Notification Bot 2014-10-28 04:11:36 UTC
Change 169314 had a related patch set uploaded by Ejegg:
Log full URLs on spam blacklist hit

https://gerrit.wikimedia.org/r/169314
Comment 9 Elliott Eggleston 2014-10-28 20:24:15 UTC
(In reply to Kunal Mehta (Legoktm) from comment #1)
> I'm not sure if there will be a simple way to do this without breaking b/c...

What's your concern re: breakage?  Is the content of Special:Log being parsed by things that expect just the matching domain?  Or is the worry that regexes shared between wikis running different versions of this extension would be inconsistent?  The patch I submitted shouldn't have the latter problem, as it constructs a full-line-matching regex for logs only when the initial regex detects a match.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links