Last modified: 2014-03-25 13:32:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T64997, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 62997 - Add Jenkins jobs for Popups extension repo
Add Jenkins jobs for Popups extension repo
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-03-24 07:15 UTC by Siebrand Mazeland
Modified: 2014-03-25 13:32 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Siebrand Mazeland 2014-03-24 07:15:15 UTC 
The Popups extension repo does not appear to have any Jenkins jobs yet. Please add them, as IMO it improves quality and awareness.
Comment 2 Prateek Saxena 2014-03-25 05:27:01 UTC 
I just pushed some code, which didn't really fix any of those errors and its not failing - https://integration.wikimedia.org/ci/job/mwext-Popups-lint/2/console

Does this mean we can close this bug?
Comment 3 Prateek Saxena 2014-03-25 05:43:06 UTC 
Its happening again https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/7/console

These errors usually go away after a `recheck` do I need to edit a .jshint file?
Comment 4 Gerrit Notification Bot 2014-03-25 06:14:52 UTC 
Change 120752 had a related patch set uploaded by Prtksxna:
Add .jshintrc file

https://gerrit.wikimedia.org/r/120752
Comment 5 Antoine "hashar" Musso (WMF) 2014-03-25 09:32:02 UTC 
The jslint job is only triggered when Javascript related files are edited (.jshint*, *.js or *.json iirc).

Requiring an empty .jshintrc file is bug https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 :-D  Should be fixed soon by making sure jshint always uses the defaults.
Comment 6 Prateek Saxena 2014-03-25 09:33:14 UTC 
I've added a non-empty .jshintrc file. Once this patch gets merged we should be able to close this bug.
Comment 7 Gerrit Notification Bot 2014-03-25 11:36:46 UTC 
Change 120752 merged by jenkins-bot:
Add .jshintrc file and update core.js to remove errors

https://gerrit.wikimedia.org/r/120752
Comment 8 Prateek Saxena 2014-03-25 13:30:36 UTC 
https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/12/console

All good, eh? We close this, eh?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links