Last modified: 2014-03-25 13:32:00 UTC
The Popups extension repo does not appear to have any Jenkins jobs yet. Please add them, as IMO it improves quality and awareness.
Done with change id https://gerrit.wikimedia.org/r/#/q/If385e647b8b464b599667d00d6a4b6a0803711a1,n,z JShint is failing though https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/1/console
I just pushed some code, which didn't really fix any of those errors and its not failing - https://integration.wikimedia.org/ci/job/mwext-Popups-lint/2/console Does this mean we can close this bug?
Its happening again https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/7/console These errors usually go away after a `recheck` do I need to edit a .jshint file?
Change 120752 had a related patch set uploaded by Prtksxna: Add .jshintrc file https://gerrit.wikimedia.org/r/120752
The jslint job is only triggered when Javascript related files are edited (.jshint*, *.js or *.json iirc). Requiring an empty .jshintrc file is bug https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 :-D Should be fixed soon by making sure jshint always uses the defaults.
I've added a non-empty .jshintrc file. Once this patch gets merged we should be able to close this bug.
Change 120752 merged by jenkins-bot: Add .jshintrc file and update core.js to remove errors https://gerrit.wikimedia.org/r/120752
https://integration.wikimedia.org/ci/job/mwext-Popups-jslint/12/console All good, eh? We close this, eh?