Last modified: 2014-06-28 17:47:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T66716, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 64716 - DismissableSiteNotice: Notice should still be hidden on the current page even if saving cookie fails


Summary:	DismissableSiteNotice: Notice should still be hidden on the current page even...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	DismissableSiteNotice (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal major (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-05-01 20:46 UTC by Ryan Kaldari
Modified:	2014-06-28 17:47 UTC (History)
CC List:	7 users (show)

See Also:	64721
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2014-05-01 20:46:54 UTC

Right now I am unable to dismiss SiteNotices on any Wikipedia projects because my local storage has been completely filled up by MediaWikiModuleStore.

When I click [dismiss], JS throws the following exception:
[Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: "<unknown>"] { code=1014, message="Persistent storage maximum size reached", result=2152924150, more...}

Being able to dismiss SiteNotices is important. It should either use cookies by default or fall back to using cookies when local storage is unavailable.

Comment 1 Ryan Kaldari 2014-05-01 21:04:47 UTC

Looks like DismissableSiteNotice actually uses $.cookie to save the dismiss state. I have no idea why that would fail if local storage is full. Strange.

Comment 2 Gerrit Notification Bot 2014-05-01 21:20:31 UTC

Change 130972 had a related patch set uploaded by Kaldari:
Make sure notice can be dismissed regardless of whether cookie is set

https://gerrit.wikimedia.org/r/130972

Comment 3 Gerrit Notification Bot 2014-05-01 21:21:15 UTC

Change 130973 had a related patch set uploaded by Ori.livneh:
Make localStorage use resilient

https://gerrit.wikimedia.org/r/130973

Comment 4 Gerrit Notification Bot 2014-05-02 10:35:31 UTC

Change 130972 merged by jenkins-bot:
Make sure notice can be dismissed even if setting cookie throws

https://gerrit.wikimedia.org/r/130972

Comment 5 Gerrit Notification Bot 2014-05-02 17:54:53 UTC

Change 130973 merged by jenkins-bot:
Make localStorage use resilient

https://gerrit.wikimedia.org/r/130973

Comment 6 Ryan Kaldari 2014-05-02 18:11:32 UTC

*** Bug 64737 has been marked as a duplicate of this bug. ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links