Last modified: 2014-06-28 17:47:27 UTC
Right now I am unable to dismiss SiteNotices on any Wikipedia projects because my local storage has been completely filled up by MediaWikiModuleStore. When I click [dismiss], JS throws the following exception: [Exception... "Persistent storage maximum size reached" code: "1014" nsresult: "0x805303f6 (NS_ERROR_DOM_QUOTA_REACHED)" location: "<unknown>"] { code=1014, message="Persistent storage maximum size reached", result=2152924150, more...} Being able to dismiss SiteNotices is important. It should either use cookies by default or fall back to using cookies when local storage is unavailable.
Looks like DismissableSiteNotice actually uses $.cookie to save the dismiss state. I have no idea why that would fail if local storage is full. Strange.
Change 130972 had a related patch set uploaded by Kaldari: Make sure notice can be dismissed regardless of whether cookie is set https://gerrit.wikimedia.org/r/130972
Change 130973 had a related patch set uploaded by Ori.livneh: Make localStorage use resilient https://gerrit.wikimedia.org/r/130973
Change 130972 merged by jenkins-bot: Make sure notice can be dismissed even if setting cookie throws https://gerrit.wikimedia.org/r/130972
Change 130973 merged by jenkins-bot: Make localStorage use resilient https://gerrit.wikimedia.org/r/130973
*** Bug 64737 has been marked as a duplicate of this bug. ***