Last modified: 2010-02-03 23:32:39 UTC
Per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/58399#c4958 there is a problem with the change tagging queries introduced in r58399. "This omits the FORCE INDEX on the change_tag table when tag filtering is being done (i.e. with rctag=foo). Without this index, there's a chance this module will crash the site, like the UI version did before r49068. Presumably rvtag and letag are also affected, but I haven't tested them." Obviously I don't want code I wrote to crash the site, but I'm not 100% sure how to fix this.
Created attachment 7010 [details] patch against r61457 Attached patch should fix this; specifies the appropriate index for recentchanges, revisions, usercontribs and logevents queries, also fixes an unrelated PHP notice in usercontribs. Only thing I'm not sure about is on CodeReview for r58399 Roan claims the index has a different name on Wikimedia wikis, in which case this won't work; is that still the case?
r61957