Last modified: 2010-05-15 15:37:54 UTC
I was unable to use an external url (i.e. http://meta.wikimedia.org/wiki/Help:Editing) for MediaWiki:edithelppage as it was always generating an internal url on pageview. Here is a patch that fixes this. Index: includes/EditPage.php =================================================================== RCS file: /cvsroot/wikipedia/phase3/includes/EditPage.php,v retrieving revision 1.176 diff -u -r1.176 EditPage.php --- includes/EditPage.php 1 Jun 2005 08:18:34 -0000 1.176 +++ includes/EditPage.php 23 Jun 2005 20:43:50 -0000 @@ -520,7 +520,7 @@ $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(), wfMsg('cancel') ); - $edithelpurl = $sk->makeUrl( wfMsg( 'edithelppage' )); + $edithelpurl = $sk->makeInternalOrExternalUrl( wfMsg( 'edithelppage' )); $edithelp = '<a target="helpwindow" href="'.$edithelpurl.'">'. htmlspecialchars( wfMsg( 'edithelp' ) ).'</a> '. htmlspecialchars( wfMsg( 'newwindow' ) );
Not sure what this means...? What's a case in which this fails, and what are the expected and actual results?
If I edit MediaWiki:edithelppage to be "http://meta.wikimedia.org/wiki/Help:Editing" instead of the default "Help:Editing", and I go to edit a page, the url for the "Editing Help" link is an internal one - "http://mymachine/wiki/index.php/Http://meta.wikimedia.org/wiki/Help:Editing". This patch lets either case work.
Fixed in EditPage.php, rev 1.178