Last modified: 2011-11-28 19:30:58 UTC
Created attachment 9555 [details] fixes error-causing usage of 'implode' in Language::commaList(), Language::semicolonList() and Language::pipeList() Implode is not being used correctly in Language::commaList(), Language::semicolonList() and Language::pipeList(). This makes these functions 100% useless. I just wanted to commit a patch but seems like I have no commit access for phase3 so here comes a patch.
http://www.php.net/manual/en/function.implode.php Note: implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.
Uh, wasn't really aware of that before. When I've been using these functions for the first time I got an error message, just tuns out this wasn't the cause, everythings ok then.
I don't consider relying on bad historical behavior a good practice within MediaWiki. This bug should stay open until someone fixes the order of our arguments to implode.
Assigning to self to review & apply.
Looks fine, cleanup is good. :) Applied in r104473.