Last modified: 2014-08-18 15:48:16 UTC
When using hhvm, there are various tests failures, as well as issues when editing claims on beta (when it works), involving selecting / finding claims by guid from the Claims (ArrayObject) object. this is due to a bug in hhvm, for which we made a patch: https://github.com/facebook/hhvm/pull/3404 1) Wikibase\Test\ClaimsSerializerTest::testGetSerializedValid with data set "grouped" (Wikibase\DataModel\Claim\Claims, array(array(array('ClaimsSerializerTest$claim-0', array('novalue', 'P42'), 'claim'), array('ClaimsSerializerTest$claim-1', array('novalue', 'P42'), 'statement', 'normal')), array(array('ClaimsSerializerTest$claim-2', array('somevalue', 'P1'), 'claim')))) getSerialized, getUnserialized roundtrip should result in input value Failed asserting that false is true. /home/travis/build/wikimedia/phase3/extensions/Wikibase/lib/tests/phpunit/serializers/SerializerBaseTest.php:98 /home/travis/build/wikimedia/phase3/extensions/Wikibase/lib/tests/phpunit/serializers/SerializerBaseTest.php:81 /home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiTestCase.php:133 2) Wikibase\Test\ClaimsSerializerTest::testGetSerializedValid with data set "list" (Wikibase\DataModel\Claim\Claims, array(array('ClaimsSerializerTest$claim-0', array('novalue', 'P42'), 'claim'), array('ClaimsSerializerTest$claim-1', array('novalue', 'P42'), 'statement', 'normal'), array('ClaimsSerializerTest$claim-2', array('somevalue', 'P1'), 'claim')), Wikibase\Lib\Serializers\SerializationOptions) getSerialized, getUnserialized roundtrip should result in input value Failed asserting that false is true. /home/travis/build/wikimedia/phase3/extensions/Wikibase/lib/tests/phpunit/serializers/SerializerBaseTest.php:98 /home/travis/build/wikimedia/phase3/extensions/Wikibase/lib/tests/phpunit/serializers/SerializerBaseTest.php:81 /home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiTestCase.php:133 3) Wikibase\Test\ChangeOpClaimTest::testApply with data set #8 (Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Claim\Statement, array(Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Claim\Statement)) Failed asserting that 4 matches expected 3. /home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimTest.php:188 4) Wikibase\Test\ChangeOpClaimTest::testApply with data set #9 (Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Claim\Statement, array(Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Claim\Statement)) Failed asserting that 4 matches expected 3. /home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimTest.php:188 5) Wikibase\Test\ChangeOpClaimTest::testApply with data set #10 (Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Claim\Claim, array(Wikibase\DataModel\Claim\Claim, Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Claim\Statement, Wikibase\DataModel\Claim\Statement), 0) Failed asserting that 5 matches expected 4.
https://github.com/facebook/hhvm/pull/3404
https://gerrit.wikimedia.org/r/#/c/154828/ merged to get the patch into wmf debian hhvm package